0.388.0 #1861
Merged
0.388.0 #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first 3 show "what could have gone better" last 2 show "what went well"
Bumps [rack-session](https://github.com/rack/rack-session) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/rack/rack-session/releases) - [Changelog](https://github.com/rack/rack-session/blob/v2.1.1/releases.md) - [Commits](rack/rack-session@v2.1.0...v2.1.1) --- updated-dependencies: - dependency-name: rack-session dependency-version: 2.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bump rack-session from 2.1.0 to 2.1.1
A-11 v2 with Radio Buttons (5 options, conditional 2nd & 3rd question)
Update form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new form type,
a11_v2_radio, which uses radio buttons for feedback and includes associated validations, UI updates, and tests. The changes ensure the new form type integrates seamlessly with the existing system while maintaining functionality and user experience.New Form Type:
a11_v2_radioa11_v2_radio, to the list of supported form kinds, with specific rules and validations for its structure and content. (app/models/form.rb,spec/models/form_spec.rb) [1] [2]ensure_a11_v2_radio_formatmethod to validate that the form includes required questions and options, such as a radio button question with values 1-5 and specific positive/negative indicators. (app/models/form.rb)UI and Behavior Enhancements
a11_v2_radioform type. (app/views/components/_form_a11_v2_radio_script.html.erb)app/views/components/forms/question_types/_radio_buttons.html.erb)Testing and Factories
a11_v2_radioto streamline test creation, including predefined questions and options. (spec/factories/form.rb) [1] [2]a11_v2_radioform type, including dynamic question visibility and successful submission. (spec/features/touchpoints_spec.rb)Miscellaneous Updates
a11_v2_radioform type. (app/views/components/widget/_fba.js.erb)find_inactive_forms_sincemethod to exclude templates when querying published forms. (app/models/form.rb)