Update documented protection levels to reflect reality #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to reflect reality, I assume the protection levels for get_cert_status_changes and get_cert_status_date got swapped in error due to the similar names.
- it looks like most of this is due to bumping most level 2 methods to level 3 - and indeed, these files were not updated in GOCDB#15 - interestingly, get_downtime_to_broadcast as documented gets knocked down to level 1. That is the level it is and, based on example output, should be.
DonaldChung-HK
approved these changes
Jul 9, 2025
DonaldChung-HK
left a comment
DonaldChung-HK
left a comment
There was a problem hiding this comment.
Looks good. Change to the documentation match the descriptions in commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume the protection levels for
get_cert_status_changesandget_cert_status_dategot swapped in error due to the similar names.It looks like most of this is due to bumping most level 2 methods to level 3 and indeed, these files were not updated in #15.
Interestingly,
get_downtime_to_broadcastas documented gets knocked down to level 1. That is the level it is and, based on example output, should be.