Conversation
Add filter for gettext files geared to translators * There is an option for maintainers that allow to review msgid texts * Includes documentation and update to aspell.po * Adds translation to spanish and minor updates to es.po * The cpp filter includes debug samples to allow others to inspect and maybe contribute with other filters * Update on gitignore to exclude intermediate doc generated files and other intermediate files appropiate for lsp editors Closes GNUAspell#410
kevina
left a comment
kevina
left a comment
There was a problem hiding this comment.
At the top of 'po.cpp' please add a copyright in your name.
All translations should go though the translation project. See https://translationproject.org/html/translators.html.
Also please do not regenerate anything in the po/ directory. This is only done when creating a release.
modules/filter/po.cpp
Outdated
| @@ -0,0 +1,283 @@ | |||
| // This file is part of The New Aspell | |||
| // Copyright (C) 2025 by Kevin Atkinson under the GNU LGPL license | |||
There was a problem hiding this comment.
Please add a proper copyright under your name.
There was a problem hiding this comment.
I just added my name, thanks for noticing, if it's best to maintain your name and mine, please let me know to modify accordingly.
There was a problem hiding this comment.
If you would consider everything in po.cpp your code than just your name is fine.
There was a problem hiding this comment.
Fixed, now is in proper shape. Thank you.
|
Thank you for your contribution. Just FYI: there was actually a simple po filter in the misc/ directory. See https://github.com/GNUAspell/aspell/blob/master/misc/po-filter.c. It is easy to miss and I am sure your code is more advance so I will go ahead and use your code. It may be a little while before I can properly review this though. |
modules/filter/po.cpp
Outdated
| @@ -1,8 +1,8 @@ | |||
| // This file is part of The New Aspell | |||
| // Copyright (C) 2025 by Igor Támara under the GNU LGPL license | |||
There was a problem hiding this comment.
If you are reusing code from somewhere else, the correct thing to do is to add a copyright line. Simply copy the Copyright notice from the file the code is from. If there is no notice then let me know let me know what code you are reusing and I will figure out the best year to use.
For example:
Copyright (C) 20XX by Kevin Atkinson under the GNU LGPL license version 2.0 or 2.1.
Copyright (C) 2025 Igor Támara ...
There was a problem hiding this comment.
I reused from markdown and looked at the commit messages for markdown.cpp, feel free to adjust if I'm not accurate.
2 participants
Add filter for gettext files geared to translators
Closes #410