Making compute_aver_align() more general and public
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimoneMartino98
approved these changes
Nov 25, 2025
Collaborator
SimoneMartino98
left a comment
SimoneMartino98
left a comment
There was a problem hiding this comment.
I see no problem; it could be useful.
matteobecchi
changed the title
compute_aver_align() more general and public
andrewtarzia
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested Reviewers: @andrewtarzia @SimoneMartino98
I modified the function compute_aver_align() so that now it can be clearly used to compute the average alignment of any local vector field associated to the particles.
I made the metric used to quantify alignment a parameter.
I made the function public so that the users can use it.