Use "armor" instead of separate values (2)#156
Closed
UmbralReaper wants to merge 1 commit intoGMC-Modding-Team:masterfrom
Closed
Use "armor" instead of separate values (2)#156UmbralReaper wants to merge 1 commit intoGMC-Modding-Team:masterfrom
"armor" instead of separate values (2)#156UmbralReaper wants to merge 1 commit intoGMC-Modding-Team:masterfrom
Conversation
As seen in Cataclysm-DDA#49679, there is a trend to move towards using 'armor'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a trend in Cataclysm-DDA (CleverRaven/Cataclysm-DDA#49679 and similar) to use
"armor"instead of explicitly declaring the different parts.This is the same as #128, just in a new PR to avoid dealing with merge conflicts.
This is a draft because I haven't playtested yet - it should work fine, but after the last tooling mistakes, I want to make sure.