Localisation#282
Draft
UmbralReaper wants to merge 11 commits intoGMC-Modding-Team:Experimental-Mod-Packfrom
Draft
Localisation#282UmbralReaper wants to merge 11 commits intoGMC-Modding-Team:Experimental-Mod-Packfrom
UmbralReaper wants to merge 11 commits intoGMC-Modding-Team:Experimental-Mod-Packfrom
Conversation
Member
Member
Contributor
Author
Sure! |
Contributor
Author
|
@TheGoatGod Travis CI appears to be failing. |
This reverts commit d496584.
Contributor
Author
|
@TheGoatGod Why would you merge this? I explicitly stated that it wouldn't have any benefit!
Even putting that aside, did you test it? Make sure that it worked properly? I certaintly haven't run any tests beyond a general smell check. EDIT: cough. Seems that I misread the merge. I apologise for my mistake. |
Contributor
Author
Member
|
https://github.com/GMC-Modding-Team/Community-Mod-Compilation-redux/pulls please move here, and i will be doing so in future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Add i18n capabilities to the mod compilation.
Content
Add a script that extracts all the name and description strings from the JSON and a workflow that automates it.
.mdfiles.nameanddescription.We could merge this now, but it would prevent doing any of the above (and wouldn't have any benefit).
Additional context
Even if nobody uses it, I still feel that we should give the option to translate mods.