Skip to content

essd review updates (round 1) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iamdonovan wants to merge 41 commits into
base: main
Choose a base branch
from
Open

essd review updates (round 1) #16

iamdonovan wants to merge 41 commits into from

Conversation

@iamdonovan
Copy link
Collaborator

@iamdonovan iamdonovan commented Nov 3, 2025 •
edited
Loading

This PR addresses most of the remaining issues raised by reviewers:

  • Adds a GitHub Action to check the dataset before anything can be merged into origin/main
  • Adds a script to update the dataset based on new/updated files in dataset/contributor_files, scripts/update_dataset.py
  • Updates contributing instructions based on level of familiarity/comfort with git/github
  • Adds a table, script showing a confusion matrix of mapping conflicts (Table 4)
  • Adds a figure, script demonstrating two glaciers with mapping conflicts (Fig. 9)
  • Fixes a few additional "level" uses and old category values

Additional changes/updates:

  • fixed DOI link for glaciers in regions 13, 15

@iamdonovan
update figure 8
da8cbfa 
- change legend label to 'category'
- decrease font size
@iamdonovan
Update README.md
ce76a61 
add zenodo badge
@iamdonovan
doi version
2ade854 
update badge to point to latest doi
@iamdonovan
add explanation of auto_term
48f532c
@iamdonovan
swap categories 1, 3
373034a
@iamdonovan
add table 4 script
9ebddf6 
- print confusion matrix as .tex
- print information about different agreements/disagreements
@iamdonovan
correct number of conflicts
b3bba56 
"mappingconflicts.csv" only has 83 rows - counting the regions, region 11 should have 9 rather than 10
@iamdonovan
add fig. 9 script, examples
6a3b679 
- add script to plot two conflict examples
- move mapping tools to map_tools.py (scale bar, image stretch)
- add conflict examples to category_examples.csv
- add lake outlines for conflict examples to lake_outlines.gpkg
- pan-sharpen with bands 543
- fix crlf lines in pansharpen_all.py
@iamdonovan
update example figures
4c2bde1 
- plot added lakes for Fig. 2b
- add Fig. 9
@iamdonovan
add fig. 9 to essd readme
774a893
@iamdonovan
one last level -> category
4909a0d
@iamdonovan
fix inventory dois
ae985f6
@iamdonovan
add a verb
cf8ba08
@iamdonovan
move environment file
0fe44b9 
move from essd/ to main directory, add gitpython as a dependency
@iamdonovan
add delayed-assert
4146fbd
@iamdonovan
add test for new csv files and gpkg files
b5cda57 
- test whether new/updated csv files have correct columns
- test whether all geopackage files (a) exist, and (b) have the correct columns
@iamdonovan
test for lake_cat values
f8c22fd 
- re-name test_column_names -> test_columns
- add list of rgi regions rather than parsing filenames
- add test to compare lake_cat values in csv files and geopackage files
@iamdonovan
add pytest dependency
aa1061c
@iamdonovan
add workflow action for running pytest
3d8de11
@iamdonovan
use v5, checkout all tags, branches
4403d94
@iamdonovan
undo checkout all tags, branches, compare to origin/main
8b5be26
@iamdonovan
re-do checkout all tags/branches
d6d4848
@iamdonovan
Merge pull request #15 from GLIMS-RGI/action
6f31bb5 
add tests + github action
@iamdonovan
remove essd_review branch (was a test)
0484086
@iamdonovan
update contributing section
30bfc34 
- add github/not github sub-sections
- explain that PR will trigger checks for formatting
- start including information about (eventual) update_dataset.py script
@iamdonovan
fix image date, lake category
f052b89
@iamdonovan
Copy link
Collaborator Author

iamdonovan commented Nov 3, 2025

Note: the geopackage files still need to be updated, and I still have to add the update_dataset.py script with instructions.

@iamdonovan
move summary_table.py to tools.py
f768372
@iamdonovan
update with new dataset layout
33eec8f
@iamdonovan
add script to update dataset
ece2004 
- check for new/updated contributor files
- check for conflicts
- if no conflicts, merge + update gpkg files
- update summary_table.csv
@iamdonovan
update gpkg files for regions 13, 15
2bff612
@iamdonovan
add tqdm to test environment
5fcc7a6
@iamdonovan iamdonovan marked this pull request as ready for review November 5, 2025 00:10
@iamdonovan
Copy link
Collaborator Author

iamdonovan commented Nov 5, 2025

gpkg files have been updated for regions 13, 15, and I have added the update script now. Final (possible) additions will be to update the mappingconflicts.csv file with glaciers that contributors agreed on, to update the confusion matrix (Table 4).

@iamdonovan
remove script (incorporated in update_dataset.py)
98d31bb
@iamdonovan
update readme
411d283 
- fix figure caption italics
- add information about the different scripts contained in the scripts folder
- fix script name
@iamdonovan
always treat contributor as str
991e245
@iamdonovan
patch to update imja/lhotse shar
6874e63
@iamdonovan
add rgi_id to missing lakes
1b3600e
@iamdonovan
update figures, table after patching region 15
2c091fb
@iamdonovan
add global comparison figure (Fig. 10)
509638e 
scatter plot of # of glaciers for each region, identified using global lake inventories and variable buffer around RGI terminus.

- script, .png file
- add CSV file for global comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iamdonovan