Fix transmissibility calculation #3940
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkachuma
requested review from
CusiniM,
OmarDuran,
castelletto1,
paveltomin,
rrsettgast and
wrtobin
as code owners
castelletto1
approved these changes
Jan 22, 2026
paveltomin
approved these changes
Jan 22, 2026
jhuang2601
approved these changes
Jan 22, 2026
Contributor
jhuang2601
left a comment
jhuang2601
left a comment
There was a problem hiding this comment.
Great, it is working for SEAM case.
The negative transmissibility is related to the old issue with vtk (inconsistent surface normal with MPI)
jhuang2601
added
type: bug
jafranc
reviewed
Jan 23, 2026
| real64 const dt0 = m_weights[iconn][0] * dCoeff_dVar[er0][esr0][ei0][0][0]; | ||
| real64 const dt1 = m_weights[iconn][1] * dCoeff_dVar[er1][esr1][ei1][0][2]; | ||
|
|
||
| dWeight_dVar[0][0] = ( dt0 * t1 * sumOfTrans - dt0 * t0 * t1 ) / ( sumOfTrans * sumOfTrans ); |
Contributor
There was a problem hiding this comment.
Shouldn't the m_transMultiplier be there too ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the transimissibility calculated between a cell and a surface element. This follows the same treatment as
CellElementStencilTPFA.As a side, the logging on
vtkExtractEdgesresults in some info messages in the log. I am disabling the logging temporarily while this filter is running.