Skip to content

Conversation

@victorapm
Copy link
Contributor

@victorapm victorapm changed the title WIP - Improve MGR recipes for thermal perf - Improve MGR recipes for thermal Jan 23, 2026
@victorapm victorapm marked this pull request as ready for review January 23, 2026 06:26
@victorapm victorapm requested a review from tjb-ltk January 23, 2026 06:27
@victorapm victorapm added flag: ready for review flag: requires updated TPL(s) Needs a specific TPL PR dependencies Pull requests that update a dependency file labels Jan 23, 2026
@victorapm victorapm changed the title perf - Improve MGR recipes for thermal perf: Improve MGR recipes for thermal Jan 23, 2026
@victorapm victorapm self-assigned this Jan 23, 2026
cprLike = 13, //!< CPR-like restriction
blockColLumped = 14 //!< Block column-lumped approximation
blockColLumped = 14, //!< Block column-lumped approximation
partialColLumped = 15 //!< Partial column-lumped approximation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "Partial column-lumped approximation" mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means W_{TS} = 0 instead of doing colsum^{-1}(A_{TS}) * colsum^{-1}(A_{SS}) as done by blockColLumped. W_{TS} being the submatrix of the restriction operator coupling temperature and densities.

The pressure part remains the same: W_{PS} = colsum^{-1}(A_{PS}) * colsum^{-1}(A_{SS})

So, I called it a "partial" column-lumped. Let me know if you have other names in mind!

Copy link
Contributor

@castelletto1 castelletto1 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for ThermalCompositionalMultiphaseFVM we have:

| A_SS A_SP A_ST |
| A_PS A_PP A_PT |
| A_TS A_TP A_TT |

With "Partial column-lumped approximation", the correction to block:

| A_PP A_PT |
| A_TP A_TT |

is

- | colsum(A_{PS})  | * colsum^{-1}(A_{SS}) * | A_SP A_ST |
  |       0         |

Correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, so essentially the energy equation isn't perturbed

Comment on lines +80 to +81
m_levelRestrictType[1] = MGRRestrictionType::partialColLumped; // True-IMPES for thermal
m_levelCoarseGridMethod[1] = MGRCoarseGridMethod::galerkin;
Copy link
Contributor

@castelletto1 castelletto1 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the use of the Galerkin projection instead of the non-Galerkin. Again, I am not sure I fully understand what partial column lumping is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment applies also to the the other two modified strategies

@victorapm victorapm added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jan 23, 2026
Copy link
Collaborator

@paveltomin paveltomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be interesting to discuss this during our solvers meeting on Thursdays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI dependencies Pull requests that update a dependency file flag: ready for review flag: requires updated TPL(s) Needs a specific TPL PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants