Skip to content

feat: Configurable Quadrature Rules for triangles/quads in ALM solver #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bd713 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

feat: Configurable Quadrature Rules for triangles/quads in ALM solver #3938

bd713 wants to merge 8 commits into from
+164 −8

Conversation

@bd713
Copy link
Contributor

@bd713 bd713 commented Jan 20, 2026

This PR:

  • Removes hard-coded quadrature order for contact interface elements (triangles and quadrilaterals) in SolidMechanicsAugmentedLagrangianContact
  • Relies on useHighOrderQuadratureRule setting from FiniteElementDiscretization, allowing:
    • Consistent quadrature accuracy between 3D and 2D elements
    • Users to control quadrature accuracy via XML input

DENEL Bertrand added 2 commits January 20, 2026 12:02
@bd713 bd713 requested a review from jafranc January 20, 2026 18:11
@bd713 bd713 self-assigned this Jan 20, 2026
@bd713 bd713 added type: feature New feature or request ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 20, 2026
@bd713 bd713 marked this pull request as draft January 21, 2026 01:05
@bd713 bd713 added DO NOT MERGE ! and removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs DO NOT MERGE ! labels Jan 21, 2026
@bd713 bd713 marked this pull request as ready for review January 21, 2026 02:33
jhuang2601
jhuang2601 approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for fixing it!

@castelletto1
Copy link
Contributor

castelletto1 commented Jan 21, 2026 •
edited
Loading

Do we want the quadrature rule to be exposed to the user?

https://github.com/GEOS-DEV/GEOS/blob/58178e42765c158f7a2f941eea098078b6f4c14a/src/coreComponents/finiteElement/FiniteElementDiscretization.cpp#L53C1-L56C91

As far as I can tell having m_useHighOrderQuadratureRule == 1 is needed to correctly integrate bubble contributions on tetrahedra and triangular faces when the ALM solver (SolidMechanicsAugmentedLagrangianContact) is used. Same thing applies to SolidMechanicsLagrangeContactBubbleStab, which was implemented by @CusiniM for the induced seismicity project and which would need some refactoring to include slip and open fracture states.

In my opinion, having an optional attribute, namely useHighOrderQuadrature, needed in the two solvers above, which must be set to 1 (for tetrahedral element subregions) is not a good design. I would not expose the option to the user and set it to true in the solver constructor.

castelletto1
castelletto1 reviewed Jan 22, 2026
View reviewed changes
...Components/physicsSolvers/solidMechanics/contact/SolidMechanicsLagrangeContactBubbleStab.cpp Outdated
Comment on lines 132 to 135
GEOS_ERROR_IF( hasTetrahedra && useHighOrderQuadrature != 1,
GEOS_FMT( "{}: Tetrahedral meshes require useHighOrderQuadratureRule=\"1\" for correct integration of bubble contributions. "
"Please add this attribute to your FiniteElements/{} XML block.",
getName(), getDiscretizationName() ) );
Copy link
Contributor

@castelletto1 castelletto1 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paveltomin paveltomin paveltomin approved these changes

@castelletto1 castelletto1 castelletto1 approved these changes

@jafranc jafranc jafranc approved these changes

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren Guotong-Ren is a code owner

@matteofrigo5 matteofrigo5 Awaiting requested review from matteofrigo5 matteofrigo5 is a code owner

Assignees

@bd713 bd713

Labels

ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bd713 @castelletto1 @paveltomin @jafranc @jhuang2601