Skip to content

Conversation

@dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Oct 24, 2025

Summary

This pull request migrates the constitutive driver tests from the unit test directory into the integrated test suite. These tests are effectively self‑contained GEOS simulation models and should be executed using the geos executable rather than through the unit-testing framework.

1. Introduced a New Base Class: ConstitutiveDriver

  • A new abstract base class ConstitutiveDriver is introduced. All constitutive drivers will eventually inherit from this class.
  • In this PR, only the PVTDriver is migrated; additional drivers will follow in subsequent PRs.

2. Output Table Registered as a restart property

  • The output table is now registered as a property within ConstitutiveDriver.
  • This property is written to the restart file, allowing the integrated test scripts to compare results against baseline restart data.

3. Consolidation of Common Parameters

  • Parameters shared across multiple constitutive drivers are moved into the new base class.

4. Updated Output Behaviour

  • If the user does not specify an output field:
    • Results are written to stdout, formatted using the new table output system.
  • If an output field is specified:
    • Results are written to a simple CSV file, which is human readable.

5. Removal of baseline Field

  • The old baseline field is removed. Since integrated tests compare against restart files, explicit baseline checks inside the constitutive drivers are no longer needed.
  • As a result, these drivers no longer function as standalone unit tests; all testing is through the integrated test framework.

6. Test Relocation and Cleanup

  • Tests moved from
    src/coreComponents/integrationTests/constitutiveTests
    to
    inputFiles/constitutiveDriver
  • Legacy baselines associated with the old unit-test-style setup are removed.

7. Documentation Updates

  • The PVTDriver documentation is updated to reflect these changes

@dkachuma dkachuma self-assigned this Oct 24, 2025
@dkachuma dkachuma added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs type: feature New feature or request labels Oct 24, 2025
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 1.65746% with 178 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.67%. Comparing base (58178e4) to head (4ecd79f).

Files with missing lines Patch % Lines
...ponents/constitutiveDrivers/ConstitutiveDriver.cpp 0.00% 98 Missing ⚠️
...constitutiveDrivers/fluid/multiFluid/PVTDriver.cpp 0.00% 50 Missing ⚠️
...utiveDrivers/fluid/multiFluid/PVTDriverRunTest.hpp 0.00% 23 Missing ⚠️
...ponents/constitutiveDrivers/ConstitutiveDriver.hpp 0.00% 5 Missing ⚠️
src/coreComponents/events/tasks/TaskBase.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3883      +/-   ##
===========================================
- Coverage    58.93%   58.67%   -0.26%     
===========================================
  Files         1351     1352       +1     
  Lines       112834   112868      +34     
===========================================
- Hits         66499    66227     -272     
- Misses       46335    46641     +306     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants