Conversation
mmpagani
approved these changes
Feb 26, 2026
Member
mmpagani
left a comment
mmpagani
left a comment
There was a problem hiding this comment.
Thanks, Fahrettin. Good job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the ground-motion intensity conversion equations (GMICE) and intensity ground-motion conversion equations (IGMCE) based on the Gallahue and Abrahamson (2023) methodology.
Utility
The implementation provides a suite of four core equations (Eq 19, 20, 22, and 23) from Gallahue and Abrahamson (2023), supporting both comprehensive "full models" and data-limited "simple models."
Test
The code's mathematical accuracy was verified across all four conversion functions using a structured unittest framework.
Robustness was ensured by testing error handling for missing data columns and invalid equation IDs.
The test suite utilizes temporary directories and automated cleanup to ensure zero-trace execution upon completion.