Safe mode: search for extends_statement node instead of accessing it by index#174
Merged
NathanLovato merged 1 commit intoGDQuest:mainfrom Nov 14, 2025
Merged
Conversation
Contributor
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173
When
class_name_statementis annotated andextends_statementis on the same line asclass_name_statement, thenextends_statementnode is the third child, not second as was described in a comment. This would preventGdTree::move_extends_statementmethod from finding theextends_statementnode and moving it.This PR adds a function that searches for a child node with a specific grammar name instead of accessing the node by index.