Skip to content

fix: implement create circle API with request body #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dk-a-dev merged 3 commits into from
Aug 2, 2025
Merged

fix: implement create circle API with request body #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a73426
fix: COMMUNITY_BASE_URL to the production API endpoint
dk-a-dev Jul 31, 2025
43ae9bb
Merge branch 'GDGVIT:dev-v3' into dev-v3
dk-a-dev Jul 31, 2025
c463a15
feat: implement create circle API with request body
dk-a-dev Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/main/java/com/dscvit/vitty/network/api/community/APICommunity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import com.dscvit.vitty.network.api.community.requests.CircleBatchRequestBody
import com.dscvit.vitty.network.api.community.requests.UsernameRequestBody
import com.dscvit.vitty.network.api.community.responses.circle.CircleBatchRequestResponse
import com.dscvit.vitty.network.api.community.responses.circle.CircleRequestsResponse
import com.dscvit.vitty.network.api.community.responses.circle.CreateCircleRequest
import com.dscvit.vitty.network.api.community.responses.circle.CreateCircleResponse
import com.dscvit.vitty.network.api.community.responses.circle.JoinCircleResponse
import com.dscvit.vitty.network.api.community.responses.requests.RequestsResponse
Expand Down Expand Up @@ -129,10 +130,10 @@ interface APICommunity {
@Header("Authorization") authToken: String,
): Call<CircleResponse>

@POST("/api/v3/circles/create/{circleName}")
@POST("/api/v3/circles/create")
fun createCircle(
@Header("Authorization") authToken: String,
@Path("circleName") circleName: String,
@Body requestBody: CreateCircleRequest //
): Call<CreateCircleResponse>

@POST("/api/v3/circles/join")
Expand Down
14 changes: 11 additions & 3 deletions app/src/main/java/com/dscvit/vitty/network/api/community/APICommunityRestClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import com.dscvit.vitty.network.api.community.requests.CircleBatchRequestBody
import com.dscvit.vitty.network.api.community.requests.UsernameRequestBody
import com.dscvit.vitty.network.api.community.responses.circle.CircleBatchRequestResponse
import com.dscvit.vitty.network.api.community.responses.circle.CircleRequestsResponse
import com.dscvit.vitty.network.api.community.responses.circle.CreateCircleRequest
import com.dscvit.vitty.network.api.community.responses.circle.CreateCircleResponse
import com.dscvit.vitty.network.api.community.responses.circle.JoinCircleResponse
import com.dscvit.vitty.network.api.community.responses.requests.RequestsResponse
Expand Down Expand Up @@ -235,11 +236,12 @@ class APICommunityRestClient {
val bearerToken = "Bearer $token"

Timber.d("APICommunityRestClient.createCircle called with circleName: $circleName")
val requestBody = CreateCircleRequest(circleName = circleName)

mApiUser = retrofit.create<APICommunity>(APICommunity::class.java)
val apiCreateCircleCall = mApiUser!!.createCircle(bearerToken, circleName)
val apiCreateCircleCall = mApiUser!!.createCircle(bearerToken, requestBody)
Timber.d("API call created with request body, enqueueing request...")

Timber.d("API call created, enqueueing request...")

apiCreateCircleCall.enqueue(
object : Callback<CreateCircleResponse> {
Expand All @@ -248,7 +250,13 @@ class APICommunityRestClient {
response: Response<CreateCircleResponse>,
) {
Timber.d("API Response received: ${response.code()}, body: ${response.body()}")
retrofitCreateCircleListener.onSuccess(call, response.body())
if (response.isSuccessful) {
retrofitCreateCircleListener.onSuccess(call, response.body())
} else {
val errorBody = response.errorBody()?.string()
Timber.e("API Error: ${response.code()} - $errorBody")
retrofitCreateCircleListener.onError(call, Throwable("API Error: ${response.code()} - ${errorBody ?: "Unknown error"}"))
}
}

override fun onFailure(
Expand Down
5 changes: 5 additions & 0 deletions ...ava/com/dscvit/vitty/network/api/community/responses/circle/CircleBatchRequestResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,8 @@ data class CircleBatchResponseItem(
data class CircleBatchRequestResponse(
val data: List<CircleBatchResponseItem>,
)


data class CreateCircleRequest(
val circleName: String
)
Loading