Skip to content

cflow: Allow overflows for Int64 shifts too #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meck-gd merged 1 commit into from
Nov 20, 2025
Merged

cflow: Allow overflows for Int64 shifts too #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions de4dot.blocks/cflow/Int32Value.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,6 @@ public static Int32Value Shl(Int32Value a, Int32Value b) {
return CreateUnknown();
if (b.Value == 0)
return a;
//if (b.Value < 0 || b.Value >= sizeof(int) * 8)
// return CreateUnknown();
int shift = b.Value;
uint validMask = (a.ValidMask << shift) | (uint.MaxValue >> (sizeof(int) * 8 - shift));
return new Int32Value(a.Value << shift, validMask);
Expand All @@ -462,8 +460,6 @@ public static Int32Value Shr(Int32Value a, Int32Value b) {
return CreateUnknown();
if (b.Value == 0)
return a;
//if (b.Value < 0 || b.Value >= sizeof(int) * 8)
// return CreateUnknown();
int shift = b.Value;
uint validMask = a.ValidMask >> shift;
if (a.IsBitValid(sizeof(int) * 8 - 1))
Expand All @@ -476,8 +472,6 @@ public static Int32Value Shr_Un(Int32Value a, Int32Value b) {
return CreateUnknown();
if (b.Value == 0)
return a;
//if (b.Value < 0 || b.Value >= sizeof(int) * 8)
// return CreateUnknown();
int shift = b.Value;
uint validMask = (a.ValidMask >> shift) | (uint.MaxValue << (sizeof(int) * 8 - shift));
return new Int32Value((int)((uint)a.Value >> shift), validMask);
Expand Down
6 changes: 0 additions & 6 deletions de4dot.blocks/cflow/Int64Value.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,6 @@ public static Int64Value Shl(Int64Value a, Int32Value b) {
return CreateUnknown();
if (b.Value == 0)
return a;
if (b.Value < 0 || b.Value >= sizeof(long) * 8)
return CreateUnknown();
int shift = b.Value;
ulong validMask = (a.ValidMask << shift) | (ulong.MaxValue >> (sizeof(long) * 8 - shift));
return new Int64Value(a.Value << shift, validMask);
Expand All @@ -405,8 +403,6 @@ public static Int64Value Shr(Int64Value a, Int32Value b) {
return CreateUnknown();
if (b.Value == 0)
return a;
if (b.Value < 0 || b.Value >= sizeof(long) * 8)
return CreateUnknown();
int shift = b.Value;
ulong validMask = a.ValidMask >> shift;
if (a.IsBitValid(sizeof(long) * 8 - 1))
Expand All @@ -419,8 +415,6 @@ public static Int64Value Shr_Un(Int64Value a, Int32Value b) {
return CreateUnknown();
if (b.Value == 0)
return a;
if (b.Value < 0 || b.Value >= sizeof(long) * 8)
return CreateUnknown();
int shift = b.Value;
ulong validMask = (a.ValidMask >> shift) | (ulong.MaxValue << (sizeof(long) * 8 - shift));
return new Int64Value((long)((ulong)a.Value >> shift), validMask);
Expand Down
Loading