Skip to content

Add ACP client session integration#37

Open
wgqqqqq wants to merge 1 commit into
GCWing:mainfrom
wgqqqqq:codex/add-acp-client-session-support
Open

Add ACP client session integration#37
wgqqqqq wants to merge 1 commit into
GCWing:mainfrom
wgqqqqq:codex/add-acp-client-session-support

Conversation

@wgqqqqq
Copy link
Copy Markdown

@wgqqqqq wgqqqqq commented May 7, 2026

Summary

This PR adds end-to-end ACP client session integration across the desktop app, CLI runtime, and Flow Chat UI.

It introduces a dedicated bitfun-acp crate, wires ACP clients into desktop session management, adds ACP-aware dispatch and session handling, and exposes ACP configuration and model/session controls in the frontend.

What Changed

  • added a new bitfun-acp crate for ACP client/runtime/server support
  • added desktop ACP APIs for client lifecycle, session creation, dialog turns, permission responses, and session model management
  • connected ACP-backed sessions into agent dispatch, session cancellation, and session cleanup flows
  • added shared agentic system initialization for ACP/CLI runtime usage
  • added Flow Chat support for ACP session creation, ACP model selection, ACP permission tool cards, and ACP-aware session restore/send flows
  • added ACP settings UI and localization entries for client configuration
  • updated session metadata handling to recognize ACP session types and derived-session relationships
  • included the review fix for ACP dispatch session persistence in remote workspaces by resolving the effective mirrored session path instead of using the raw remote path

Why

This change makes ACP clients first-class participants in the existing Sparo desktop experience instead of a separate side path.

Users can now create and interact with ACP-backed sessions from the same workspace/session surfaces, while the runtime can correctly persist, restore, dispatch, and moderate ACP interactions using the same session model the rest of the app already relies on.

Impact

  • desktop users can start ACP sessions directly from workspace actions and interact with them in Flow Chat
  • ACP sessions can surface tool confirmation requests in the existing tool card UX
  • ACP-backed session routing and reuse now work for remote workspaces without writing session state to the wrong path
  • the CLI gains ACP server entry support for ACP runtime hosting

Validation

  • cargo check -p bitfun-desktop
  • cargo check -p bitfun-cli
  • pnpm run type-check:web

@wgqqqqq wgqqqqq force-pushed the codex/add-acp-client-session-support branch from 682431d to 3a3a418 Compare May 11, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant