Skip to content

fix: remove duplicate image dependency declarations #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgqqqqq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove duplicate image dependency declarations #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ hostname = "0.4"

# QR code generation
qrcode = "0.14"
image = { version = "0.25", default-features = false, features = ["png"] }

# WebSocket client
tokio-tungstenite = { version = "0.21", features = ["native-tls"] }
Expand Down
1 change: 0 additions & 1 deletion src/crates/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ hostname = { workspace = true }

# QR code generation
qrcode = { workspace = true }
image = { workspace = true }

# WebSocket client
tokio-tungstenite = { workspace = true }
Expand Down
13 changes: 11 additions & 2 deletions src/crates/core/src/agentic/coordination/coordinator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,15 @@ impl ConversationCoordinator {
agent_type: String,
skip_tool_confirmation: bool,
) -> BitFunResult<()> {
self.start_dialog_turn_internal(session_id, user_input, None, turn_id, agent_type)
.await
self.start_dialog_turn_internal(
session_id,
user_input,
None,
turn_id,
agent_type,
skip_tool_confirmation,
)
.await
}

pub async fn start_dialog_turn_with_image_contexts(
Expand All @@ -191,6 +198,7 @@ impl ConversationCoordinator {
Some(image_contexts),
turn_id,
agent_type,
false,
)
.await
}
Expand All @@ -202,6 +210,7 @@ impl ConversationCoordinator {
image_contexts: Option<Vec<ImageContextData>>,
turn_id: Option<String>,
agent_type: String,
skip_tool_confirmation: bool,
) -> BitFunResult<()> {
// Get latest session (re-fetch each time to ensure latest state)
let session = self
Expand Down