[BUG] fmbox loses first header for EML files#524
Open
seliger wants to merge 2 commits intoGAM-team:mainfrom
Open
[BUG] fmbox loses first header for EML files#524seliger wants to merge 2 commits intoGAM-team:mainfrom
seliger wants to merge 2 commits intoGAM-team:mainfrom
Conversation
fmbox was treating eml files like mbox files, assuming the first line was a "From" header, but this is not always the case. For example, Mailcow uses dovecotadm to export Maildir formatted spools that do not have From: as the first line of headers and that header was getting lost. This change works around the issue by rewinding to the beginning of the file if the first line does not start with "From:".
[BUG] fmbox loses first header for EML files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmbox was treating eml files like mbox files, assuming the first line was a "From" header, but this is not always the case. For example, Mailcow uses doveadm from Dovecot to export Maildir-formatted spools that do not have From: as the first header line, and that header was getting lost.
This change works around the issue by rewinding to the beginning of the file if the first line does not start with "From:".
Below is an example header from one of the eml files processed.
To test this, I came up with this snippet.
If you swap the two headers in the eml file, you can see where the top line is always removed. For me, this was breaking GYB from shunting email into the correct label structures.
I'm not saying this is the best solution, but it works for my use case and respects files that start with an actual "From:" header on the first line, like traditional mbox bundles.