SeaSaltPaper pull request #341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented Draw phase Implemented basic classes for cards
doesnt work tho, cant cast Card to SeaSaltPaperCard for some reason??
Barely displaying anything Stuff get squished and just missing
Adding mermaids
Add CRAB and SWIMMER suite rename ShellDuo to CrabDuo SailorSharkDuo to SwimmerSharkDuo
Implement LastChance Implement processEndRound
Tested SSP with fmtesters Implement proper copy for SeaSaltPaperParameters and SeaSaltPaperCard
for CrabDuo and SwimmerSharkDuo
Only redeterminize DrawPiles and other PlayerHands DiscardPiles are still considered perfectly observable
Implement redeterminize according to individual card visibility
hopshackle
reviewed
Dec 2, 2025
| config.put(RunArg.mode, "exhaustiveSP"); | ||
| } else { | ||
| config.put(RunArg.mode, "exhaustive"); | ||
| config.put(RunArg.mode, "random"); |
Collaborator
There was a problem hiding this comment.
This needs to be put back to exhaustive. (An additional check to see if we have to move to random is fine; and there is now Utils.gamePerMatchup that could be used for this purpose).
hopshackle
reviewed
Dec 2, 2025
Comment on lines
+260
to
261
| System.out.println("Playing game " + (i+1) + " out of " + totalGameBudget); | ||
| List<Integer> matchup = new ArrayList<>(nTeams); |
Collaborator
There was a problem hiding this comment.
Need to remove temporary logging (or put it behind a debug/verbose flag)
hopshackle
requested changes
Dec 2, 2025
|
|
||
| //Redeterminize hidden info (unless playerID == -1) | ||
| if (playerId != -1 && getCoreGameParameters().partialObservable) { | ||
| // TODO handle discardPiles too |
Collaborator
There was a problem hiding this comment.
In case it helps, the Utils.DeterminisationUtilities may now make this straightforward?
| sspg.resetTurn(); | ||
| return true; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Why not just return this...this Actions seems to be Immutable?
Collaborator
|
Looks good - changes are I think minor to undo a couple of changes in the core framework. Suggestions for Sea Salt Paper itself are purely optional. (And hurrah for adding FM tests!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (should) only include SeaSaltPaper (hopefully)