fix: add set_url method to http_request for atomic URL updates#25
Merged
Conversation
qrdl
approved these changes
May 22, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the HttpRequest API to support consistent (“atomic”) request URL rewrites by introducing a single method that updates nginx’s uri, args, and unparsed_uri fields together.
Changes:
- Add
HttpRequest::set_url(path, query)to updateuri,args, andunparsed_uriin one call and clearvalid_unparsed_uri. - Add
HttpRequest::uri()accessor. - Minor formatting fix in
send_local_responseoutput filter call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+264
to
+272
| /// Atomically update the request URL: path, query string and unparsed_uri. | ||
| /// All three nginx fields (`uri`, `args`, `unparsed_uri`) are updated and | ||
| /// `valid_unparsed_uri` flag is cleared so nginx will rebuild it if needed. | ||
| /// | ||
| /// `path` should be just the path (e.g. `/foo/bar`). | ||
| /// `query` should be the query string without leading `?` (empty for no query). | ||
| pub fn set_url(&mut self, path: &[u8], query: &[u8]) -> anyhow::Result<()> { | ||
| let pool = self | ||
| .pool() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.