fix test-runner fastedge-cli issue#42
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a FastEdge CLI discovery issue in the test runner by making bundled-binary path resolution robust across install/bundle layouts, and adjusts the library bundling pipeline to better handle node:* built-ins and CommonJS dependencies when emitting ESM.
Changes:
- Update FastEdge-run CLI discovery to locate the package root by walking up to the
@gcoredev/fastedge-testpackage.json, then derive bundled binary paths from that root. - Update esbuild lib bundling to externalize all
node:*imports via a resolve plugin and add an ESMrequireshim banner to avoid runtime failures when CommonJS code is inlined.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/utils/fastedge-cli.ts | Adds package-root discovery and simplifies bundled CLI path candidates to be rooted at the resolved package root. |
| esbuild/bundle-lib.js | Improves Node built-in externalization for node:* specifiers and adds an ESM require shim banner for bundled output stability. |
Fastedge node tests no longer pollute the Rust folder structure
qrdl
approved these changes
May 22, 2026
Collaborator
Author
|
🎉 This PR is included in version 0.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.