wasi http host#137
Merged
Merged
Conversation
- Simplified hostname resolution by consistently prioritizing `server_name` and backend configurations. - Reordered and tidied imports for better readability. - Updated `HOST` header propagation logic for accuracy.
- Replaced hardcoded `LOCALHOST` with dynamic backend hostname resolution. - Added validation for backend hostname configuration and parsing. - Updated `HOST` header propagation using the resolved backend hostname.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts hostname/Host-header handling in the WASI HTTP executor path, and includes a small import formatting change.
Changes:
- Simplifies
httpimports formatting incrates/http-service/src/lib.rs. - Updates
WasiHttpExecutorImpl::executeto derive a backend host header from the backend’s configured hostname and use it for the propagatedHostheader.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/http-service/src/lib.rs | Minor formatting change to consolidate http imports. |
| crates/http-service/src/executor/wasi_http.rs | Changes hostname resolution and sets propagated Host header based on backend hostname. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
May 11, 2026
godronus
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.