feat: New macros, cleanup and clarification on flag arguments #271
+736
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying devdocs with
|
| Latest commit: |
ec27091
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b0b2b183.devdocs-next.pages.dev |
| Branch Preview URL: | https://gil-chore-more-macros.devdocs-next.pages.dev |
Owen-sz
requested changes
Jan 14, 2026
| - Defer to what the desktop file originally contained if you are unsure which to use. | ||
|
|
||
| ### %desktop_file_install | ||
| SHOULD be used to install a .desktop file. |
Member
There was a problem hiding this comment.
Update the policy/guidelines/wherever the .desktop stuff is to do this/link to this
| #### %npm_build | ||
| SHOULD be used for building Electron or Tauri apps with NPM. Has a great deal of flags to work around NPM specific limitations. | ||
|
|
||
| Available flags: |
Member
There was a problem hiding this comment.
Examples for these would be nice too
Co-authored-by: Owen Zimmerman <123591347+Owen-sz@users.noreply.github.com>
Owen-sz
requested changes
Jan 17, 2026
| See [Development and Shared Libraries](/terra/guidelines#development-and-shared-libraries) section. | ||
|
|
||
| Install `.desktop` file to `%_appsdir` for graphical apps. [Guide here](/terra/guidelines#providing-your-own-desktop-file). Prefer upstream provided ones over manually generating one. | ||
| Install `.desktop` file to `%_appsdir` for graphical apps. [Guide here](/terra/guidelines#providing-your-own-desktop-file). Prefer upstream provided ones over manually generating one. It is RECOMMENDED to use our [.desktop file macros](/terra/srpm#desktop-file-macros) for installing and editing .desktop files. |
Member
There was a problem hiding this comment.
Shouldn't this be MUST or SHOULD?
Collaborator
Author
There was a problem hiding this comment.
I based it off how other parts like this were worded TBH.
pages/terra/guidelines.mdx
Outdated
| # and other development files (.vapi, .typelib, .gir, etc.). | ||
| ``` | ||
| ### JavaScript | ||
| These are guidelines for packaging projects written in oe which utilize [JavaScript](https://developer.mozilla.org/en-US/docs/Web/JavaScript). |
pages/terra/guidelines.mdx
Outdated
|
|
||
| <Callout type="info"> | ||
| "Node modules" in this document refers to JavaScript packages run using a JavaScript runtime (usually Node.js), which are hosted on the [NPM Registry](https://www.npmjs.com).<br /> | ||
| "JavaScript modules," however, refers to to JavaScript packages run using a JavaScript runtime which are hosted on *either* the NPM Registry or the [JavaScript Registry](https://jsr.io), the latter of which are also called "modern JavaScript packages." This means Node modules are JavaScript modules, but not the other way around.<br /> |
| SHOULD be used in place of manually creating `-static` subpackages. | ||
| **NOTE:** You still need to define a `%package static{:rpmspec}`, and then use this macro below this. | ||
| <Callout type="warning"> | ||
| You still need to define a `%package static`, and then use this macro below this. |
Member
There was a problem hiding this comment.
Suggested change
| You still need to define a `%package static`, and then use this macro below this. | |
| You still need to define a `%package static`, and then use this macro below that. |
| SHOULD be used in place of manually creating `-libs` subpackages. | ||
| **NOTE:** You still need to define a `%package libs{:rpmspec}`, and then use this macro below this. | ||
| <Callout type="warning"> | ||
| You still need to define a `%package libs`, and then use this macro below this. |
Member
There was a problem hiding this comment.
Suggested change
| You still need to define a `%package libs`, and then use this macro below this. | |
| You still need to define a `%package libs`, and then use this macro below that. |
Collaborator
Author
There was a problem hiding this comment.
This is referring to the macro displayed directly above it so wouldn't "this" be more correct? (Plus all I did was move the existing text into a callout for formatting reasons.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.