test: add tests for accesslimit_count behavior; refactor entity helpers #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the accesslimit_count functionality in the keymaster integration, as requested in PR #551 review. The tests verify that access limit counts are properly decremented when locks are unlocked, including parent-child lock relationships and edge cases.
Changes:
- Added test for float-to-int conversion in NumberEntity for accesslimit_count
- Added tests for accesslimit_count decrement behavior in lock unlock events
- Added type annotation for consistency in coordinator.py
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_number.py | Added test verifying float values from NumberEntity frontend are converted to integers when stored in accesslimit_count |
| tests/test_coordinator_events.py | Added three tests for accesslimit_count decrement: basic decrement, parent lock decrement for child locks, and prevention of negative values |
| custom_components/keymaster/coordinator.py | Added type annotation to accesslimit_count variable for consistency with parent lock code path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add test for float-to-int conversion when setting accesslimit_count via NumberEntity - Add tests for accesslimit_count decrement on lock unlock: - Basic decrement when slot is used - Parent lock decrement for child locks - No decrement when count is already at 0 - Add type annotation for consistency in coordinator.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
raman325
force-pushed
the
fix/accesslimit-count-tests
branch
from
8bb670a to
a6b6e7b
Compare
- Merge _get_code_slots_num and _get_day_of_week_num into _get_x_num - Use Literal type for property_name parameter - Simplify __init__ by removing redundant guard checks - Reorder attribute initialization for clarity Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
raman325
changed the title
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Rename test functions and update method calls from _get_code_slots_num
and _get_day_of_week_num to _get_x_num("code_slots") and
_get_x_num("accesslimit_day_of_week") respectively.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add test coverage for accesslimit_count functionality as requested in PR #551 review, plus refactor entity.py helper methods.
Proposed change
Tests
test_number.py:
test_number_entity_converts_float_to_int_for_accesslimit_count: Verifies that float values from NumberEntity frontend are properly converted to integers when stored in the code slottest_coordinator_events.py:
test_lock_unlocked_decrements_accesslimit_count: Verifies the count is decremented when a lock is unlocked with a code slottest_lock_unlocked_decrements_parent_lock_accesslimit_count: Verifies parent lock's count is decremented for child locks not overriding parenttest_lock_unlocked_does_not_decrement_when_count_zero: Verifies count doesn't go negativeRefactoring
entity.py:
_get_code_slots_numand_get_day_of_week_numinto single_get_x_nummethodLiteraltype for property_name parameter for type safety__init__by removing redundant guard checks (already handled in helper method)coordinator.py:
accesslimit_countvariable for consistency (PR fix: accesslimit_count not decrementing on lock use #551 review comment)Type of change
Additional information