1285 repository full di migration part 1#1295
Conversation
…ragment.kt to use DI
…ion tray close handling
# Conflicts: # .github/workflows/compatibilityTest.yml
|
@ThomasKiljanczykDev We need to find a way on how to work together. I am not comfortable with letting you do all the work, because eventually I am responsible for the app and need to understand what it does and how it works. So I suggest the following: You continue until a certain point and then stop and let me continue. I think it does not work to refactor in parallel. Edit: Ok, I was able to rebase my branch on yours without issue... So maybe it does work after all. I will reconsider and see to it that we get both branches merged. |
|
@Futsch1 your PR is smaller, so it has priority. Removing the ReminderContext will be needed but it's omnipresent in the codebase, so your approach with the intermediate glue to make it work with Hilt at places is sound. I could have made this PR as a draft and wait for the other to complete. |
…EditMedicineFragment.kt
|
@ThomasKiljanczykDev |
|
@ThomasKiljanczykDev |
# Conflicts: # app/src/main/java/com/futsch1/medtimer/MainActivity.kt # app/src/main/java/com/futsch1/medtimer/overview/ReminderViewHolder.kt # app/src/main/java/com/futsch1/medtimer/reminders/ReminderProcessorBroadcastReceiver.kt # app/src/main/java/com/futsch1/medtimer/reminders/RemoteInputReceiver.kt
…ess for notification dismissal
…ication tray is really closed
…t.repeatingReminders test due to its unreliability
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@Futsch1 this PR should be ready for final review/approval. Please re-run the failed checks if you can. I have implemented some test reliability changes so the tablet (API 28) tests should not fail. |
Futsch1
left a comment
Futsch1
left a comment
There was a problem hiding this comment.
Just a minor one regarding the test, accepting the TODO change would be ok for me now to get this PR merged. I will then add my next PR for preparing further DI work
ThomasKiljanczykDev
deleted the
1285-repository-full-DI-migration-part-1
branch
3 participants
@Futsch1 this one continues the work on using DI to inject repositories everywhere their used.
I have split it into arbitrary parts to limit the scope of individual PRs
There are a handful of instrumented tests changes.
I have encountered some hurdles there and spent bulk of my work on resolving them.
This includes changes to the notification tray open/closes handling and dialog handling.
I've also reduced the attempts from the default 10 to 3, because otherwise it took eternity for the tests to finish if a lot of them were failing.