Skip to content

fix(sdk): align DistributorClient stats address docs#258

Draft
ramimbo wants to merge 1 commit into
Fundable-Protocol:mainfrom
ramimbo:fix/distributor-stats-address-docs
Draft

fix(sdk): align DistributorClient stats address docs#258
ramimbo wants to merge 1 commit into
Fundable-Protocol:mainfrom
ramimbo:fix/distributor-stats-address-docs

Conversation

@ramimbo
Copy link
Copy Markdown

@ramimbo ramimbo commented May 1, 2026

Summary

  • Remove unused actualUser / actualToken locals from DistributorClient stats methods.
  • Update getUserStats / getTokenStats JSDoc to match the AddressParam signature.
  • Drop stale overload tests for unsupported wrapper-object inputs.

Fixes #256.

Validation

  • corepack pnpm --filter @fundable/sdk exec vitest --run src/__tests__/overloads.test.ts
  • git diff --check

Notes

Broader SDK checks currently fail outside this patch:

  • corepack pnpm --filter @fundable/sdk build fails on existing src/utils/GasEstimator.ts syntax errors.
  • corepack pnpm --filter @fundable/sdk test -- --runInBand fails in unrelated GasEstimator, BalanceWatcher, deployer, transaction, stream history, and error utility tests.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 1, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a137e9f0-f158-4000-92bf-41b08c796fa0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdk(DistributorClient): getUserStats/getTokenStats compute actualUser/actualToken but never use them; JSDoc claims an unsupported wrapper-object input

1 participant