docs: fix Japanese language tag in example.py comment #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed <|jp|> to <|ja|> to match the actual tokenizer implementation. The LANGUAGES dict in cosyvoice/tokenizer/tokenizer.py defines 'ja' for Japanese, not 'jp'. This fixes the misleading comment that could cause issues like FunAudioLLM#621. Fixes FunAudioLLM#1683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
example.pycomment<|jp|>to<|ja|>to match the actual tokenizer implementationDetails
The comment at line 21 in
example.pyincorrectly documents the Japanese language tag as<|jp|>, but the actualLANGUAGESdict incosyvoice/tokenizer/tokenizer.pydefines it as"ja": "japanese"(line 19).This mismatch can cause confusion and issues like #621 when users follow the documented tag.
Test Plan
LANGUAGESdict in tokenizer.py usesjafor JapaneseFixes #1683