Add support for private Confluence instances#3
Open
dsoprea wants to merge 4 commits intoFulcrumTechnologies:masterfrom
Open
Add support for private Confluence instances#3dsoprea wants to merge 4 commits intoFulcrumTechnologies:masterfrom
dsoprea wants to merge 4 commits intoFulcrumTechnologies:masterfrom
Conversation
Also, switched from using `exit("...")` to separate print and exit
calls. This is considered better etiquette.
Installing the package now properly installs the stuff that it depends on.
This helps debug if there's an issue with your environment variables or instance of Confluence.
Author
|
Bueller? |
Muddytm
approved these changes
Jun 22, 2020
Contributor
Muddytm
left a comment
Muddytm
left a comment
There was a problem hiding this comment.
Apologies for the wait. Thanks for your input! :)
Muddytm
approved these changes
Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also fixed a couple of other things that I tripped over.