Open
Conversation
Contributor
|
Maybe its just me, but I expect the block rate display the same as ingame even though its wrong to avoid confusion. |
Contributor
Author
|
That makes sense. But Frostiae already mentioned in the info that
It seems that the current calculated block rate doesn’t quite match what we observe in the game, and the max and min limits might no longer apply. I made these changes based on the reasons mentioned above. Let’s wait and see what Frostiae’s final thoughts are. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This pull request implements a calculation for the true block chance in the Calculations tab.
It adjusts the block rate display to show the actual probability directly, as the in-game display is inaccurate and the block rate on the Calculations tab currently requires further conversion.
Correct me if there are any issues.
Thanks!