Skip to content

feat(core): add symbol note query APIs#77

Merged
mors119 merged 1 commit into
FrilLab:mainfrom
mors119:feature/symbol-query-api
Jun 17, 2026
Merged

feat(core): add symbol note query APIs#77
mors119 merged 1 commit into
FrilLab:mainfrom
mors119:feature/symbol-query-api

Conversation

@mors119

@mors119 mors119 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

feat(core): add symbol note query APIs

Type of Change

  • feat
  • fix
  • docs
  • refactor
  • test
  • chore

Required

  • cargo check passes
  • cargo fmt --all --check passes
  • cargo clippy --workspace --all-targets -- -D warnings passes
  • cargo test passes

Checklist

  • Code builds successfully
  • Tests pass
  • Documentation updated

Summary by CodeRabbit

  • New Features

    • Added symbol-based note management: users can now list and retrieve notes associated with specific code symbols for improved organization and targeted access.
  • Tests

    • Comprehensive test coverage added for new symbol-scoped note operations.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Two new public methods are added to NoteService: list_symbol_notes filters list_notes results to only NoteAnchor::Symbol variants, and find_symbol_note performs a case-insensitive lookup within those results. Two unit tests validate symbol-only filtering and content correctness for the lookup.

Changes

Symbol-scoped note listing and lookup

Layer / File(s) Summary
list_symbol_notes and find_symbol_note implementation and tests
crates/frilvault-core/src/note/note_service.rs, crates/frilvault-core/src/tests/note_service_test.rs
list_symbol_notes wraps list_notes and retains only NoteAnchor::Symbol(_) entries. find_symbol_note lowercases the input symbol and returns the first matching NoteView or None. Tests cover filtering (one line-anchored + one symbol-anchored note, expects one result) and exact content of the found symbol note.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 Hop through the symbols, one by one,
Filter the anchors till the right one's won.
Lowercase the name, let case-folding be,
Return the first match — or None, carefree.
New methods added, the tests pass with glee! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding symbol note query APIs to the core module, which aligns with the implementation of list_symbol_notes and find_symbol_note methods.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mors119 mors119 merged commit 2b0b070 into FrilLab:main Jun 17, 2026
2 of 3 checks passed
@mors119 mors119 deleted the feature/symbol-query-api branch June 17, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant