[TASK] add missing subclasses entries in Classes.php #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukasniestroj
commented
Jan 9, 2023
lukasniestroj
commented
- provide a "sublasses" entry for the parent class
- add missing "recordType" for the child classes
- omit empty lines in generated Classes.php arrays
Contributor
Author
|
@PKuhlmay I am not sure whether to drop the parts in https://github.com/FriendsOfTYPO3/extension_builder/blob/master/Resources/Private/CodeTemplates/Extbase/ext_typoscript_setup.txtt with this change 🤔 |
* provide a "sublasses" entry for the parent class * add missing "recordType" for the child classes * omit empty lines in generated Classes.php arrays
PKuhlmay
force-pushed
the
master
branch
2 times, most recently
from
135b509 to
62c8064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.