You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is one small issue with this approach, but I think we can ignore that.
Older Shopware 6 versions had a very open PHP Version constraint like >=7.2 which allows all PHP versions after 7.2.
This seems to be fixed in shopware/platform with 6.4.0.0 and only affects older versions.
Updated the PR to include the built data from the changes in the script.
What kinda "hits" us here, is that older SW6 Versions have a very open PHP version constraint like >=7.2 which basically means that every PHP version after 7.2 is valid - which includes e.g. 8.x.
Not sure if this is even relevant, since the newer versions seem to handle the constraint correctly, like 6.5.0.0 depends on PHP ~8.1.0 || ~8.2.0.
If it's relevant, I guess we need to hard code the versions, since there is no (reasonable) way to change the PHP constraint for old SW 6 Versions.
Updated the code to not introduce a breaking change, since that would break shopware-cli which has a link to data/php-version.json built into the binary.
I've named the new file data/all-supported-php-versions-by-shopware-version.json to have a name that represents what's in there. But I'm open to change the file name when someone comes up with a better one ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new generator to load all supported PHP versions for each
shopware/platformversion.The data in the following format and gets generated based on the
phpsemver constraint incomposer.jsonfor each version.The change is made to have the data available in https://github.com/FriendsOfShopware/platform-plugin-dev-docker to specify which PHP versions we need to build for each Shopware release. See FriendsOfShopware/platform-plugin-dev-docker#25 for more details.
There is one small issue with this approach, but I think we can ignore that.
Older Shopware 6 versions had a very open PHP Version constraint like
>=7.2which allows all PHP versions after 7.2.This seems to be fixed in
shopware/platformwith 6.4.0.0 and only affects older versions.