Feat: see all performance settings / toggle done settings

[zukucker]

Hey,

tried my best to implement a solution for #360 .
Please let me know if if i can do anything better.

[schneider-felix]

Looks good to me.

I think it could be a bit better if you refactored the checkers a bit. Instead of adding an else clause to each checker, I would add a new static function to SettingsResult.

Theoretically you could also add a constructor to SettingsResult, but that would be a breaking change and I know that there are people who use this class in their plugins.

So I would do it like this:
Add a new static function SettingsResult::create() which takes the same parameters as the other static functions but also additionally takes the state as the first parameter. With that, you can simply remove the if-else clause from the checkers and use the SettingsResult::create() function instead.

[zukucker]

Hi, thank you - way better solution. You are absolute right. ill do it asap 👍