Skip to content

Fixed issue #295 #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niempi2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed issue #295 #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CADability/Make3D.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,7 +1008,11 @@ public static IGeoObject MakePipe(IGeoObject faceShellOrPath, Path along, Projec
}
if (pos >= 0.0)
{ // position the face at the beginning of the curve
GeoVector normal = (along.StartDirection ^ along.EndDirection).Normalized;
GeoVector normal;
if (along.StartDirection != along.EndDirection)
normal = (along.StartDirection ^ along.EndDirection).Normalized;
else
along.StartDirection.ArbitraryNormals(out normal, out _);
GeoVector dir = along.DirectionAt(pos).Normalized;
ModOp m = ModOp.Fit(along.PointAt(pos), new GeoVector[] { dir, normal, normal ^ dir },
along.StartPoint, new GeoVector[] { along.StartDirection.Normalized, normal, normal ^ along.StartDirection.Normalized });
Expand Down