Skip to content

[CFM_237] Update FridgeInformation Component Responsiveness for Desktop #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1jeanpaul1 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[CFM_237] Update FridgeInformation Component Responsiveness for Desktop #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 41 additions & 46 deletions src/components/molecules/FridgeInformation/FridgeInformation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,42 +132,27 @@ InformationLine.propTypes = {
function ImageContainer({ src = null, alt, isAboveFold = false }) {
if (src) {
return (
<>
<Box
sx={{
display: { xs: 'block', sm: 'none' },
width: '100%',
}}
>
<Image
src={src}
alt={alt}
width="100%"
height="100%"
layout="responsive"
objectFit="contain"
priority={isAboveFold}
/>
</Box>
<Stack
direction="row"
justifyContent="center"
sx={{
display: { xs: 'none', sm: 'inherit' },
width: '100%',
}}
>
<Image
src={src}
alt={alt}
width="300px"
height="345px"
layout="fixed"
objectFit="contain"
priority={isAboveFold}
/>
</Stack>
</>
<Box
sx={{
position: 'relative',
width: '100%',
maxHeight: { xs: 300, md: 345 },
aspectRatio: '1 / 1.15',
display: 'flex',
justifyContent: 'center',
backgroundColor: '#F5F5F5',
borderRadius: 3,
overflow: 'hidden',
}}
>
<Image
src={src}
alt={alt}
layout="fill"
objectFit="contain"
priority={isAboveFold}
/>
</Box>
);
} else return null;
}
Expand Down Expand Up @@ -391,17 +376,27 @@ ReportContainer.propTypes = {

export default function FridgeInformation({ fridge, report }) {
return (
<Stack direction="column" spacing={5} mx={4} mb={4}>
{FridgeContainer({ fridge })}
{ReportContainer({ report })}
<Box
sx={{
width: '100%',
maxWidth: { md: 900 },
mx: 'auto',
px: { xs: 4, sm: 6 },
mb: 4,
}}
>
<Stack direction="column" spacing={5}>
{FridgeContainer({ fridge })}
{ReportContainer({ report })}

<ButtonLink
aria-label="Click to report the status of the fridge"
variant="contained"
to={`/user/fridge/report/${fridge.id}`}
title="Update Status"
/>
</Stack>
<ButtonLink
aria-label="Click to report the status of the fridge"
variant="contained"
to={`/user/fridge/report/${fridge.id}`}
title="Update Status"
/>
</Stack>
</Box>
);
}
FridgeInformation.propTypes = {
Expand Down