Skip to content

include FrendsTaskMetadata#55

Merged
MatteoDelOmbra merged 1 commit intomainfrom
FSPW-722-ListObjectVersions
Feb 25, 2026
Merged

include FrendsTaskMetadata#55
MatteoDelOmbra merged 1 commit intomainfrom
FSPW-722-ListObjectVersions

Conversation

@MichalFrends1
Copy link
Contributor

@MichalFrends1 MichalFrends1 commented Feb 23, 2026

Please review my changes :)

Review Checklist

  • Task version updated (x.x.0)
  • CHANGELOG.md updated
  • Solution builds
  • Warnings resolved (if possible)
  • Typos resolved
  • Tests cover new code
  • Description how to run tests locally added to README.md (if needed)
  • All tests pass locally

Summary by CodeRabbit

Release Notes – Version 1.1.0

  • Bug Fixes
    • Fixed an issue ensuring package metadata is properly included in NuGet package distributions

@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d41057 and 36ff05f.

📒 Files selected for processing (2)
  • Frends.AmazonS3.ListObjectVersions/CHANGELOG.md
  • Frends.AmazonS3.ListObjectVersions/Frends.AmazonS3.ListObjectVersions/Frends.AmazonS3.ListObjectVersions.csproj

Walkthrough

Version 1.1.0 release for Frends.AmazonS3.ListObjectVersions with a fix to ensure FrendsTaskMetadata.json is properly included in the NuGet package. The project version is bumped and the packaging configuration for the metadata file is updated.

Changes

Cohort / File(s) Summary
Version and Packaging Configuration
Frends.AmazonS3.ListObjectVersions.csproj
Bumps project version from 1.0.0 to 1.1.0. Modifies FrendsTaskMetadata.json inclusion by adding a Content entry with Pack="true", PackagePath="/", and CopyToOutputDirectory="PreserveNewest" attributes, while retaining the AdditionalFiles entry.
Changelog
CHANGELOG.md
Adds a new 1.1.0 entry dated 2026-02-23 documenting the fix for ensuring FrendsTaskMetadata.json is included in the NuGet package.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Fspw 703 #53 — Directly modifies the same ListObjectVersions.csproj file to update version and FrendsTaskMetadata.json packaging configuration.

Suggested reviewers

  • MatteoDelOmbra
  • RikuVirtanen

Poem

🐰 A metadata fix hops into view,
Version bumped to 1.1, shiny and new!
NuGet packages now include with care,
The metadata file—a treasure to share! 📦✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'include FrendsTaskMetadata' directly reflects the main change: ensuring FrendsTaskMetadata.json is included in the NuGet package by modifying the project file configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch FSPW-722-ListObjectVersions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MatteoDelOmbra MatteoDelOmbra merged commit bca5420 into main Feb 25, 2026
5 checks passed
@MatteoDelOmbra MatteoDelOmbra deleted the FSPW-722-ListObjectVersions branch February 25, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants