Conversation
bahiirwa
approved these changes
Jan 25, 2026
DanieleAlessandra
approved these changes
Jan 26, 2026
Collaborator
DanieleAlessandra
left a comment
There was a problem hiding this comment.
Thanks for the clear explanation and for referencing the WordPress core change.
The reasoning makes sense and the implementation looks solid to me.
Removing the manual enqueue of json2 in the SDK is safe and aligns with WordPress 6.9 behavior.
LGTM 👍
6d832f7 to
032b238
Compare
Contributor
|
Thanks @johnbillion and @DanieleAlessandra |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WordPress 6.9, the
json2library was no-oped as it's no longer needed by any browser. This was done as part of a larger change to remove support for old IE conditional syntax. See https://core.trac.wordpress.org/ticket/63821 and WordPress/wordpress-develop@49d1ded.This PR removes
json2from the Freemius SDK. This should be a safe change to make because:json2then it'll still get enqueued via the normal script dependency system in WordPress. Thejson2script is still registered, it's just no longer enqueued manually by the Freemius SDK.json2library provides polyfills forJSON.stringify()andJSON.parse()by pushing its implementations onto the globalJSONobject. No browsers need this back compat, and there is nothing provided injson2which is not provided byJSONin the browser.Fixes #840.