Update get_socrates script to obtain code from FormingWorlds/SOCRATES repo#661
Merged
Update get_socrates script to obtain code from FormingWorlds/SOCRATES repo#661
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SOCRATES installer script to clone from FormingWorlds/SOCRATES instead of nichollsh/SOCRATES, aligning PROTEUS with the new upstream location.
Changes:
- Adds dependency checks (NetCDF, NetCDF-Fortran, gfortran) before installation.
- Switches git clone URLs to
FormingWorlds/SOCRATES. - Adjusts install location logic and post-build validation messaging.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
=======================================
Coverage 69.03% 69.03%
=======================================
Files 98 98
Lines 10114 10114
Branches 1400 1400
=======================================
Hits 6982 6982
Misses 2792 2792
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timlichtenberg
approved these changes
Mar 24, 2026
Member
timlichtenberg
left a comment
There was a problem hiding this comment.
Test locally, works perfectly. Clever setup logic!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have moved from nichollsh/SOCRATES to FormingWorlds/SOCRATES, which enables us to remain in sync with the Metoffice repo.
This PR updates the
get_socrates.shscript to reflect this change. It is a copy of theget_socrates.shscript from AGNI.Validation of changes
Obtains SOCRATES from correct repo and maintains all existing functionality. Tested on Fedora 43 with Python 3.12.
Checklist
Relevant people
@timlichtenberg