Skip to content

Update get_socrates script to obtain code from FormingWorlds/SOCRATES repo#661

Merged
nichollsh merged 3 commits intomainfrom
hn/getsocrates
Mar 24, 2026
Merged

Update get_socrates script to obtain code from FormingWorlds/SOCRATES repo#661
nichollsh merged 3 commits intomainfrom
hn/getsocrates

Conversation

@nichollsh
Copy link
Member

@nichollsh nichollsh commented Mar 24, 2026

Description

We have moved from nichollsh/SOCRATES to FormingWorlds/SOCRATES, which enables us to remain in sync with the Metoffice repo.

This PR updates the get_socrates.sh script to reflect this change. It is a copy of the get_socrates.sh script from AGNI.

Validation of changes

Obtains SOCRATES from correct repo and maintains all existing functionality. Tested on Fedora 43 with Python 3.12.

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

Relevant people

@timlichtenberg

Copilot AI review requested due to automatic review settings March 24, 2026 10:37
@nichollsh nichollsh marked this pull request as ready for review March 24, 2026 10:37
@nichollsh nichollsh requested a review from a team as a code owner March 24, 2026 10:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SOCRATES installer script to clone from FormingWorlds/SOCRATES instead of nichollsh/SOCRATES, aligning PROTEUS with the new upstream location.

Changes:

  • Adds dependency checks (NetCDF, NetCDF-Fortran, gfortran) before installation.
  • Switches git clone URLs to FormingWorlds/SOCRATES.
  • Adjusts install location logic and post-build validation messaging.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.03%. Comparing base (ee834f0) to head (d229aac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #661   +/-   ##
=======================================
  Coverage   69.03%   69.03%           
=======================================
  Files          98       98           
  Lines       10114    10114           
  Branches     1400     1400           
=======================================
  Hits         6982     6982           
  Misses       2792     2792           
  Partials      340      340           
Flag Coverage Δ
unit-tests 56.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@timlichtenberg timlichtenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally, works perfectly. Clever setup logic!

@nichollsh nichollsh merged commit 91ca821 into main Mar 24, 2026
10 checks passed
@nichollsh nichollsh deleted the hn/getsocrates branch March 24, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants