Conversation
…se escape=30% and different time-stepping.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CHILI intercomparison helper scripts and associated configs to regenerate CHILI-formatted outputs from the latest PROTEUS runs, including updated scalar/profile CSV content and intercomparison-specific runtime settings.
Changes:
- Update
tools/chili_postproc.pyto produce CHILI-spec scalar + profile CSVs (new columns, revised ordering, profile extraction viaread_ncdf_profile, viscosity extraction from SPIDER JSONs). - Update CHILI intercomparison configs to match agreed protocol settings (notably escape efficiency and time-stepping/output cadence), and enable SLURM for the CHILI grid config.
- Adjust PROTEUS internals: add
combine_edgesoption toread_ncdf_profile, and update the adaptive timestep minimum-relative term.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/chili_postproc.py | Reworks CHILI CSV generation (scalars + tau profiles), adds new columns (e.g., viscosity) and switches profile reading to read_ncdf_profile. |
| tools/chili_generate.py | Changes default output path generation to write under scratch/ and appends per-planet directories. |
| src/proteus/interior/timestep.py | Adjusts minimum timestep computation by removing a * 0.01 factor in the relative minimum term. |
| src/proteus/atmos_clim/common.py | Extends read_ncdf_profile with a combine_edges option and updates docstring/type annotation. |
| input/chili/intercomp/_base.toml | Updates CHILI intercomparison runtime parameters and sets escape efficiency to 0.3. |
| input/chili/intercomp/_base.grid.toml | Enables SLURM for the intercomparison grid runs. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
+ Coverage 69.03% 69.12% +0.09%
==========================================
Files 98 98
Lines 10114 10123 +9
Branches 1400 1401 +1
==========================================
+ Hits 6982 6998 +16
+ Misses 2792 2791 -1
+ Partials 340 334 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have re-run the CHILI intercomparison simulations with PROTEUS. This means that CHILI uses the latest version of the code.
Checklist
Relevant people
@timlichtenberg @MarijnJ0 @EmmaPostolec