Zero-length array allocation inspection (idea) by RusTit · Pull Request #504 · ForestryMC/Binnie

RusTit · 2018-04-05T13:10:48Z

Text:
Reports on allocations of arrays with known lengths of zero. Since array lengths in Java are non-modifiable, it is almost always possible to share zero-length arrays, rather than repeatedly allocating new zero-length arrays. Such sharing may provide useful optimizations in program runtime or footprint. Note that this inspection does not report zero-length arrays allocated as static final fields, as it is assumed that those arrays are being used to implement array sharing.
And also I removed two methods. They are the same as those of the parent class.

…tedOreIngredient.java

…e as in parent class.

RusTit · 2018-04-07T06:15:11Z

@Nedelosk please review.

RusTit · 2018-04-12T23:25:58Z

No problem, but it can take some time.

mezz · 2018-04-13T02:07:53Z

 		return itemStack;
 	}

+	private static final int MAX_ITEM_DAMAGE = 16387;


Any idea what the significance of this number is?
I thought it might be a power of 2 minus 1, but the nearest power of 2 is 2^14 (16384) which is also a weird number.

No idea, I was trying to find this value (binnie, forestry, forge) but no successed

Max seems to be OreDictionary.WILDCARD_VALUE at 32767 so this doesn't even have the right number of bits.

mezz · 2018-04-13T02:11:16Z

+	@Nullable
+	private static Pattern PATTERN;
+
+	private static Pattern GetPattern() {


Method names should start with a lowercase letter.

Actually I think this should just be created statically instead of using a singleton getter, since it is not very expensive to create and does not pull in lots of other classes.

private static Pattern PATTERN = Pattern.compile("_", Pattern.LITERAL);

In this case it is not. At first version I do like you describe. But after mc run, it crushed with NullPointException in

@Override public String toString() { return GetPattern().matcher(super.toString().toLowerCase(Locale.ENGLISH)).replaceAll(StringUtils.EMPTY); }

Where is some issue with object creating (initial). At moment then toString invoked PATTERN will be null.

Hm enums are weird, I guess they are being constructed before static. This is fine then.

mezz · 2018-04-13T02:15:59Z

 	@SideOnly(Side.CLIENT)
 	public void onRenderBackground(int guiWidth, int guiHeight) {
-		Object texture = CraftGUITexture.BUTTON_DISABLED;
+		Object texture;


One nice use of final is for cases like this. You can make final Object texture; and the static analyzer will complain "variable 'texture' might not have been initialized" if there is a case where it is not set.

I introduced the proposed changes, but it seems that the static analyzer worked correctly without them.

mezz · 2018-04-13T02:17:07Z

 		this.branchDescription.clear();
 		String desc = branch.getDescription();
-		if (desc == null || Objects.equals(desc, "") || desc.contains("for.")) {
+		if (desc == null || desc.length() == 0 || desc.contains("for.")) {


You can use org.apache.commons.lang3.StringUtils#isEmpty to check desc

mezz · 2018-04-13T02:22:08Z

+		for (int row = 0; row < rowCount; ++row) {
+			for (int column = 0; column < columnCount; ++column) {
+				final ControlSlot slot = new ControlSlot.Builder(this, column * 18, row * 18)
+                        .assign(InventoryType.PLAYER,column + row * columnCount);


this line is using spaces for indentation, the one above is tabs

mezz · 2018-04-13T02:22:48Z

 			tooltip.add(slot.getName());
 			if (tooltipFlag.isAdvanced()) {
-				Collection<EnumFacing> inputSides = slot.getInputSides();
+                Collection<EnumFacing> inputSides = slot.getInputSides();


this line indents with spaces

mezz · 2018-04-13T02:22:52Z

 					tooltip.add(TextFormatting.GRAY + I18N.localise(ModId.CORE, "gui.side.insert", MachineSide.asString(inputSides)));
 				}
-				Collection<EnumFacing> outputSides = slot.getOutputSides();
+                Collection<EnumFacing> outputSides = slot.getOutputSides();


this line indents with spaces

mezz · 2018-04-13T02:23:32Z

 	public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
 		super.addInformation(stack, worldIn, tooltip, flagIn);
-		IItemMiscProvider item = this.getItem(stack.getItemDamage());
+        IItemMiscProvider item = this.getItem(stack.getItemDamage());


this line indents with spaces

mezz · 2018-04-13T02:23:36Z

 	@Override
 	public String getItemStackDisplayName(final ItemStack stack) {
-		IItemMiscProvider item = this.getItem(stack.getItemDamage());
+        IItemMiscProvider item = this.getItem(stack.getItemDamage());


this line indents with spaces

mezz · 2018-04-13T02:24:12Z

+		if ((!FluidRegistry.registerFluid(bFluid)) || (FluidRegistry.addBucketForFluid(bFluid))) {
+			Log.error("Liquid registered incorrectly - {} ", fluid.getIdentifier());
+		}
+    }


this line indents with spaces

…ero_Array

mezz

there are indentation issues in the latest commits

mezz · 2018-04-16T01:30:12Z

Please do not add more commits on to this PR, it needs to be reviewed and merged but that gets harder with more commits.
You can create a new PR for more changes.

RusTit · 2018-04-16T01:34:47Z

Ok, but to make clear, where is still some bugs:

Item icons painting on second layer. (Some description is above).
Event key passing in ComponentCompartmentInventory.java and WindowCompartment.java (read my dialog with Nedelosk).

RusTit · 2018-04-16T01:36:44Z

Item icon painting bug appears not only in the search window.
You can also see it in the slider (in which custom tab settings are set).

mezz · 2018-04-16T01:37:22Z

If you have specific fixes for the changes made in this PR, I think that is fine.
I am just worried that this PR is going out of control, it seems to be fixing too many different things.

RusTit · 2018-04-16T01:39:28Z

Not yet. I do not know how to fix a bug with rendering. I will fix the error with the key a little later with separate commits (will be last in this PR)

RusTit · 2018-04-16T03:18:04Z

Apparently there is no bug with keys.
I did debugging by checking the passed string-keys through the events, in everything is ok.
P.S. but the bug with the renderer I can not solve myself.

KorDum · 2018-04-16T06:31:31Z

Tabs indent or spaces?

RusTit added 16 commits April 5, 2018 22:35

AbstractMod.java

dc9f9df

AlvearyLogicStimulator.java

2247599

AnalystPageFruit.java

87d0f00

BlockDesign.java

234b863

Botany.java remove override method. It is same with AbstractMod

2fe06eb

ComponentTankContainer.java

f730dca

ContainerCraftGUI.java

9306a88

DefaultMachineInventory.java

6c75184

DefaultTankContainer.java

d0d8bb1

Engineering.java

62d828a

ErrorState.java

0e4c264

WindowGenesis.java

a81a986

TransferRequest.java

e6ae7a7

WindowCompartment.java

f42565a

MachineComponent.java, ManagerMachine.java, ItemSerumArray.java, Rota…

2f551a0

…tedOreIngredient.java

FlowerRoot.java - remove method override getRandomTemplate. It is sam…

f25638a

…e as in parent class.

RusTit mentioned this pull request Apr 6, 2018

Code bugs. #505

Merged

Nedelosk requested a review from mezz April 6, 2018 13:53

RusTit added 2 commits April 7, 2018 13:08

Merge branch 'master-MC1.12' into memory_zero_Array

491bca8

Refactoring and clean up

f9efc57

RusTit force-pushed the memory_zero_Array branch from 01634d4 to f9efc57 Compare April 7, 2018 03:48

RusTit added 5 commits April 7, 2018 14:57

Small refactor

3164761

Small refactor

67f6167

Small refactor

9e66628

AlleleHelper.java - add final to vars in methods.

56e3a6c

Refactoring BreedingSystem.java

1546d7c

RusTit added 3 commits April 7, 2018 16:17

Gene.java

fffb54d

Code cleanup

a5dbd38

Code cleanup

0ea7cbc

Русских Анатолий added 2 commits April 13, 2018 11:35

Remove final from vars

2b66108

Merge remote-tracking branch 'main/HEAD' into memory_zero_Array

c3a6edc

mezz requested changes Apr 13, 2018

View reviewed changes

RusTit added 5 commits April 14, 2018 11:42

Method names should start with a lowercase letter.

a25d01b

Improve variable.

6db93dc

Change checking for string emptiness.

2706a2e

Improve intends

35833f9

Improve localise in ControlLiquidTank.java

f9a801f

mezz approved these changes Apr 14, 2018

View reviewed changes

Русских Анатолий added 9 commits April 16, 2018 08:20

Merge branch 'master-MC1.12' into memory_zero_Array

aa1ad08

Merge remote-tracking branch 'origin/memory_zero_Array' into memory_z…

5f740e8

…ero_Array

Refactor tab slots array init.

8bd8a46

Extract createTab from lambda

0ec3efb

Refactoring compartment window.

0595121

Code clean up

1de8fe8

Extract slide and localize

894fc28

Extract method createTabNameControl

b1fca09

Extract method createTabIconControl

483d57c

mezz requested changes Apr 16, 2018

View reviewed changes

Русских Анатолий added 2 commits April 16, 2018 11:25

Refactoring and localizing compartment

241d31e

indentation

01b2c61

Remove unused comment.

839e476

Conversation

RusTit commented Apr 5, 2018

Uh oh!

RusTit commented Apr 7, 2018

Uh oh!

RusTit commented Apr 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

temp1011 Apr 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mezz left a comment

Choose a reason for hiding this comment

Uh oh!

mezz commented Apr 16, 2018

Uh oh!

RusTit commented Apr 16, 2018

Uh oh!

RusTit commented Apr 16, 2018

Uh oh!

mezz commented Apr 16, 2018

Uh oh!

RusTit commented Apr 16, 2018

Uh oh!

RusTit commented Apr 16, 2018

Uh oh!

KorDum commented Apr 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

temp1011 Apr 13, 2018 •

edited

Loading