feat(forestadmin-client): add fallback to ForestHttpApi for partial server interfaces#1414
Open
feat(forestadmin-client): add fallback to ForestHttpApi for partial server interfaces#1414
Conversation
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
…erver interfaces When a partial ForestAdminServerInterface is provided to buildApplicationServices, methods that are not implemented will now fallback to the default ForestHttpApi implementation. This allows consumers to override only the methods they need. This fixes the issue where partial implementations (like ForestAdminServerSwitcher in cloud-lambda-layers) would fail when calling methods they didn't implement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
d438d70 to
17eb01d
Compare
- Fix tests to verify Proxy behavior through actual services instead of calling methods directly - Add proper Symbol property handling in Proxy's get trap 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
withDefaultImplementationfunction that wraps partialForestAdminServerInterfacewith a ProxyForestHttpApidefault implementationbuildApplicationServicesnow acceptsPartial<ForestAdminServerInterface>instead of full interfaceProblem
After PR #1411 (centralize HTTP calls), partial implementations like
ForestAdminServerSwitcherincloud-lambda-layerswould fail when calling methods they didn't implement (e.g.,checkSchemaHash,postSchema).The comment in
ForestAdminServerSwitcherstated:But this behavior was never actually implemented - there was no fallback mechanism.
Solution
Use a Proxy to intercept method calls on the provided interface:
ForestHttpApiimplementationTest plan
yarn workspace @forestadmin/forestadmin-client test)yarn workspace @forestadmin/forestadmin-client lint)yarn workspace @forestadmin/forestadmin-client build)🤖 Generated with Claude Code