interpret symlinks as alias#264
Open
kdiogenes wants to merge 1 commit intoFontCustom:masterfrom
kdiogenes:master
Open
interpret symlinks as alias#264kdiogenes wants to merge 1 commit intoFontCustom:masterfrom kdiogenes:master
kdiogenes wants to merge 1 commit intoFontCustom:masterfrom
kdiogenes:master
Conversation
|
This works well for us - thanks :) @kaizau please consider pulling this into the main version, it's a useful feature IMHO. |
|
+1 |
JakeBeresford
requested changes
Jun 12, 2017
Collaborator
JakeBeresford
left a comment
JakeBeresford
left a comment
There was a problem hiding this comment.
Let me know if you're not able to make this change and I'll try to take care of it
| end | ||
| end | ||
|
|
||
| files.each do |file| |
Collaborator
There was a problem hiding this comment.
This second iterator is unnecessary, move this logic in to the iterator above and change the conditional logic to handle File.symlink? within the same loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.