Skip to content

Make parakeetTdtCtc110m folderName consistent with other Parakeet models #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex-Wengg merged 7 commits into from
Mar 28, 2026
+5 −10
Merged

Make parakeetTdtCtc110m folderName consistent with other Parakeet models #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05ac224
Simplify folderName logic by stripping -coreml suffix by default
Alex-Wengg Mar 28, 2026
c3aba6a
Update kokoro folderName test expectation to match simplified logic
Alex-Wengg Mar 28, 2026
8b79517
Keep kokoro and sortformer special cases to avoid breaking changes
Alex-Wengg Mar 28, 2026
443cd03
Add plda-parameters.json to OfflineDiarizer required models
Alex-Wengg Mar 28, 2026
05699cb
Merge branch 'main' into fix/parakeet-tdt-ctc-110m-folder-consistency
Alex-Wengg Mar 28, 2026
60b40f2
Add speaker-diarization path to PLDA candidate paths
Alex-Wengg Mar 28, 2026
15a4f19
Merge branch 'main' into fix/parakeet-tdt-ctc-110m-folder-consistency
Alex-Wengg Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/FluidAudio/Diarizer/Offline/Core/OfflineDiarizerModels.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public struct OfflineDiarizerModels: Sendable {
private static func loadPLDAPsi(from directory: URL) throws -> [Double] {
let candidatePaths = [
directory.appendingPathComponent("plda-parameters.json", isDirectory: false),
directory.appendingPathComponent("speaker-diarization/plda-parameters.json", isDirectory: false),
directory.appendingPathComponent("speaker-diarization-coreml/plda-parameters.json", isDirectory: false),
directory.appendingPathComponent("speaker-diarization-offline/plda-parameters.json", isDirectory: false),
]
Expand Down
12 changes: 3 additions & 9 deletions Sources/FluidAudio/ModelNames.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,16 +129,8 @@ public enum Repo: String, CaseIterable {
return "nemotron-streaming/560ms"
case .sortformer:
return "sortformer"
case .lseend:
return "ls-eend"
case .pocketTts:
return "pocket-tts"
case .multilingualG2p:
return "charsiu-g2p-byt5"
case .parakeetTdtCtc110m:
return "parakeet-tdt-ctc-110m"
default:
return name
return name.replacingOccurrences(of: "-coreml", with: "")
}
}
}
Expand Down Expand Up @@ -166,6 +158,7 @@ public enum ModelNames {
public static let fbank = "FBank"
public static let embedding = "Embedding"
public static let pldaRho = "PldaRho"
public static let pldaParameters = "plda-parameters.json"

public static let segmentationFile = segmentation + ".mlmodelc"
public static let fbankFile = fbank + ".mlmodelc"
Expand All @@ -182,6 +175,7 @@ public enum ModelNames {
fbankPath,
embeddingPath,
pldaRhoPath,
pldaParameters,
]
}

Expand Down
2 changes: 1 addition & 1 deletion Tests/FluidAudioTests/ASR/Parakeet/ModelNamesTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ final class ModelNamesTests: XCTestCase {
// Verify name (repo slug with -coreml suffix)
XCTAssertEqual(repo.name, "parakeet-tdt-ctc-110m-coreml")

// Verify folder name (simplified local folder name)
// Verify folder name (simplified - strips -coreml suffix by default)
XCTAssertEqual(repo.folderName, "parakeet-tdt-ctc-110m")

// Should have no subpath (not a variant repo)
Expand Down
Loading