Skip to content

Fix various bugs: heap memory limit, manifest link, docker env vars, …#5922

Open
mct2056 wants to merge 2 commits intoFlowiseAI:mainfrom
mct2056:bugfix/various-fixes
Open

Fix various bugs: heap memory limit, manifest link, docker env vars, …#5922
mct2056 wants to merge 2 commits intoFlowiseAI:mainfrom
mct2056:bugfix/various-fixes

Conversation

@mct2056
Copy link

@mct2056 mct2056 commented Mar 6, 2026

Fix various bugs: heap memory limit, manifest link, docker env vars, …

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses several identified bugs and implements minor improvements across the application. It enhances the Docker deployment by exposing Flowise authentication environment variables, prevents potential out-of-memory issues in the server by increasing the Node.js heap limit, refines the Gmail tool's draft update functionality with a more explicit schema, and improves web app integration by adding a manifest link.

Highlights

  • Heap Memory Limit: Increased the Node.js heap memory limit to 4GB in the server's run script to prevent potential out-of-memory errors during execution.
  • Docker Environment Variables: Exposed FLOWISE_USERNAME and FLOWISE_PASSWORD as environment variables within the docker-compose.yml configuration, allowing for easier setup and management of Flowise authentication in Docker deployments.
  • Gmail Tool Schema Refinement: Refined the schema for the Gmail UpdateDraftTool to explicitly define fields such as id, to, subject, body, cc, and bcc, providing more granular control and clarity for updating email drafts.
  • Web App Manifest Link: Added a manifest link to index.html in the UI package, which can improve the web application's integration and user experience on various platforms.
Changelog
  • docker/docker-compose.yml
    • Added FLOWISE_USERNAME and FLOWISE_PASSWORD to the list of environment variables passed to the service.
  • packages/components/nodes/tools/Gmail/core.ts
    • Replaced the generic CreateDraftSchema with a detailed z.object schema for the update_draft tool, specifying id, to, subject, body, cc, and bcc fields.
  • packages/server/bin/run
    • Modified the shebang line to include --max-old-space-size=4096, setting the Node.js heap memory limit to 4GB.
  • packages/ui/public/index.html
    • Inserted a <link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> tag within the <head> section.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses several bug fixes, including increasing the Node.js heap memory limit, adding a missing PWA manifest link, and updating Docker environment variables. It also corrects the schema for the Gmail UpdateDraftTool to include the required draft id. However, a critical Email Header Injection vulnerability was identified in the UpdateDraftTool schema due to a lack of CRLF character validation in email header fields. Please address this security concern. Additionally, consider improving the maintainability of the schema change by reusing an existing schema definition.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant