Fixes to password reset functionality

[christopherholland-workday]

FLOWISE-246

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the password reset functionality by improving the handling and validation of temporary tokens and their expiry dates. The changes ensure that the database schema for tokenExpiry is correctly defined and that the application logic consistently uses null for cleared tokens, leading to more robust and error-resistant password reset flows.

Highlights

• Database Schema Update: The tokenExpiry column in the User entity was updated to explicitly define its type as datetime and set a default of null, moving away from @CreateDateColumn which implies automatic creation/update.
• Consistent Null Handling: The tempToken field is now consistently set to null instead of an empty string ('') when cleared, aligning with its nullable: true database definition.
• Enhanced Token Validation: Added explicit checks to ensure tempToken and tokenExpiry are not null before proceeding with password reset logic, preventing potential errors during validation.

Changelog

• packages/server/src/enterprise/database/entities/user.entity.ts
  • Updated tokenExpiry column definition to datetime with null default.
• packages/server/src/enterprise/services/account.service.ts
  • Modified tempToken assignments from empty string to null.
  • Added null checks for tempToken and tokenExpiry during password reset validation.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several fixes to the password reset functionality. The changes primarily focus on improving robustness by adding checks for null or undefined tokens and expiry dates. The temporary token is now consistently cleared by setting it to null instead of an empty string. I've pointed out a minor inconsistency where tokenExpiry is set to undefined instead of null, which could lead to unexpected behavior with TypeORM.