Allow JSON columns to be used as the dateColumn in MySQL

[SentisMR]

What

This PR allows passes the dateColumn through the Illuminate MySQL grammar wrapper so that you can use JSON columns. Fixes #71

Why

We have dates in JSON columns that we would like to use to trend. The "where_between" call already allows this but the "date_format" does not.

How

Simply call the MySqlGrammar->wrap on the column name instead of injecting the string directly into the date format call.

[sarpavci]

In order to use MySqlGrammar you need to provide the connection information. You also need to add the Trend class.

laravel-trend/src/Trend.php

Lines 171 to 181 in 5ace11d

	protected function getSqlDate(): string
	{
	$adapter = match ($this->builder->getConnection()->getDriverName()) {
	'mysql', 'mariadb' => new MySqlAdapter(),
	'sqlite' => new SqliteAdapter(),
	'pgsql' => new PgsqlAdapter(),
	default => throw new Error('Unsupported database driver.'),
	};
	return $adapter->format($this->dateColumn, $this->interval);
	}

    protected function getSqlDate(): string
    {
        $connection = $this->builder->getConnection();
        $adapter = match ($connection->getDriverName()) {
            'mysql', 'mariadb' => new MySqlAdapter($connection),
            'sqlite' => new SqliteAdapter(),
            'pgsql' => new PgsqlAdapter(),
            default => throw new Error('Unsupported database driver.'),
        };

        return $adapter->format($this->dateColumn, $this->interval);
    }

[sarpavci]

Suggested change

	use Illuminate\Database\Query\Grammars\MySqlGrammar;
	use Illuminate\Database\ConnectionInterface;
	use Illuminate\Database\Query\Grammars\MySqlGrammar;

[sarpavci]

Suggested change

	$wrappedColumn = (new MySqlGrammar)->wrap($column);
	return "date_format({$wrappedColumn}, '{$format}')";
	$wrappedColumn = (new MySqlGrammar($this->connection))->wrap($column);
	return "date_format({$wrappedColumn}, '{$format}')";

[sarpavci]

Or basically you can do:

laravel-trend/src/Trend.php

Lines 171 to 181 in 5ace11d

	protected function getSqlDate(): string
	{
	$adapter = match ($this->builder->getConnection()->getDriverName()) {
	'mysql', 'mariadb' => new MySqlAdapter(),
	'sqlite' => new SqliteAdapter(),
	'pgsql' => new PgsqlAdapter(),
	default => throw new Error('Unsupported database driver.'),
	};
	return $adapter->format($this->dateColumn, $this->interval);
	}

    protected function getSqlDate(): string
    {
        $adapter = match ($this->builder->getConnection()->getDriverName()) {
            'mysql', 'mariadb' => new MySqlAdapter(),
            'sqlite' => new SqliteAdapter(),
            'pgsql' => new PgsqlAdapter(),
            default => throw new Error('Unsupported database driver.'),
        };

        return $adapter->format(
            column: $this->builder->getGrammar()->wrap($this->dateColumn), // <--- HERE
            interval: $this->interval
        );
    }

[SentisMR]

I think that the only place the connection gets used (in the mysql grammar anyways) is escaping raw sql and doing upserts. The code as written works in our environment. But your suggestion of grabbing the connection in the trend instead and pulling the builders grammar is cleaner. Thanks @sarpavci

[sarpavci]

I think you can checkout this file :)

[sarpavci]

@Larsklopstra Please take a look at this PR.