fix: Remove redundant poll loops for created Ingress, Service and Deployment resources#332
Open
ppawlowski wants to merge 1 commit intomainfrom
Open
fix: Remove redundant poll loops for created Ingress, Service and Deployment resources#332ppawlowski wants to merge 1 commit intomainfrom
ppawlowski wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes three
setIntervalpoll loops that follow creation ofDeployment,ServiceandIngressresources.Each loop polled the Kubernetes API until the resource was found, treating this as a prerequisite before proceeding. However, a successful resource create call already guarantees the resource is written to the API server and immediately readable - there is no inconsistency possibility. The loops resolved on their very first tick in every normal case, providing no correctness value.
Removing them reduces the number of Kubernetes API calls per project creation from up to 8 (5 creates + 3 reads) down to 5.
Related Issue(s)
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel