Skip to content

Conversation

@sosnovsky
Copy link
Collaborator

This PR fixes isServiceWorker check, to make it work correctly in the upcoming Chrome 144 release

close #6141


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky marked this pull request as ready for review January 5, 2026 08:43
@sosnovsky
Copy link
Collaborator Author

Hi @ioanatflowcrypt, @martgil, can you please approve this PR as it fixes issue which breaks FlowCrypt extension in Chrome 144 (it's public release is scheduled on the next week, so we should release update on this week):
Screenshot 2026-01-05 at 12 22 38

@ioanatflowcrypt
Copy link
Collaborator

Hmmm... Checked PR but still same in my side.
Could you check again?

@sosnovsky
Copy link
Collaborator Author

@ioanatflowcrypt thanks for checking! looks like I initially tested with removed Firefox-specific code. I pushed fix which removes this Firefox check, as updated code works well in Firefox too. please re-check on your side

Copy link
Collaborator

@ioanatflowcrypt ioanatflowcrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thank you👍

@sosnovsky sosnovsky enabled auto-merge (squash) January 5, 2026 13:31
@sosnovsky sosnovsky merged commit c48ca8e into master Jan 5, 2026
11 checks passed
@sosnovsky sosnovsky deleted the 6141-fix-service-worker-check branch January 5, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatibility with Google Chrome 144 Beta

3 participants