-
-
Notifications
You must be signed in to change notification settings - Fork 498
Add option to show taskbar when Flow Launcher is opend #4177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
VictoriousRaptor
wants to merge
7
commits into
dev
Choose a base branch
from
copilot/add-show-taskbar-option
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−1
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
05bd6d1
Add option to show taskbar when Flow Launcher is invoked
Copilot 8f89b86
Fix: Use ABM_ACTIVATE instead of ABM_SETSTATE for temporary taskbar s…
Copilot bed3457
Remove unnecessary unsafe keyword from ShowTaskbar method
Copilot 1b345d2
Fix missing closing braces in Win32Helper.cs
Copilot 586944c
Change wording from 'invoked' to 'opened' in localization strings
Copilot b17beec
Show/hide tasking when showing/hiding Flow
VictoriousRaptor a096729
Remove unused APPBARDATA
VictoriousRaptor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard
HideTaskbar()with state so show/hide stay balancedWiring the feature through
Show()/Hide()is good, but right nowHideTaskbar()is gated only by the current value ofSettings.ShowTaskbarWhenInvoked. That means:Show()won’t have calledShowTaskbar(), butHide()will callHideTaskbar().Show()will have calledShowTaskbar(), butHide()will skipHideTaskbar().Given this uses an undocumented taskbar message, unbalanced calls risk leaving the taskbar in a different mode than the user expects.
Consider tracking a simple flag, e.g.
bool _taskbarShownByFlow;, settrueonly whenShowTaskbar()is actually invoked inShow(), and use that flag to decide whether to callHideTaskbar()inHide()(and reset it tofalseafterward). That keeps your interaction with the shell clearly symmetric regardless of when the setting is toggled.Also applies to: 2211-2215
🤖 Prompt for AI Agents