Bump ToolGood.Words.Pinyin from 3.0.1.4 to 3.1.0

[dependabot]

Bumps ToolGood.Words.Pinyin from 3.0.1.4 to 3.1.0.

Commits

• See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[taooceros]

It does introduce a significant memory usage. Although I think it is acceptable, since that will only apply to people who uses pinyin (and it does provide better pinyin).

[jjw24]

1. How much memory difference are we talking?

2. What better Pinyin does it provide with the upgrade?

[taooceros]

around 100M

I don't really know what exactly more pinyin is provided. Probably check the commit history? toolgood/ToolGood.Words.Pinyin@dcf03a4

[jjw24]

I feel like maybe we should delay this upgrade unless there are some issue/missing pinyin, a 100mb increase is quite a lot and can be mistaken as flow itself taking up a lot of memory. What do you think?

[taooceros]

I feel like maybe we should delay this upgrade unless there are some issue/missing pinyin, a 100mb increase is quite a lot and can be mistaken as flow itself taking up a lot of memory. What do you think?

well sure

[jjw24]

Just converting this to draft until we actually need to bump it.

[Jack251970]

Continue in #3846

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.